Skip to content

remove unnecessary checks #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Aug 25, 2022
Merged

remove unnecessary checks #517

merged 21 commits into from
Aug 25, 2022

Conversation

Taz03
Copy link
Member

@Taz03 Taz03 commented Aug 15, 2022

closes #512

@Taz03 Taz03 added enhancement New feature or request priority: normal labels Aug 15, 2022
@Taz03 Taz03 self-assigned this Aug 15, 2022
@Zabuzard
Copy link
Member

While at it, might also want to remove the role checks on most of the moderation commands. Would be interesting how much we code we can remove there :)

@Taz03 Taz03 marked this pull request as ready for review August 16, 2022 22:26
@Taz03 Taz03 requested review from a team as code owners August 16, 2022 22:26
@Taz03 Taz03 requested a review from Zabuzard August 16, 2022 22:29
@DevSerendipity
Copy link
Contributor

How did you figure out what what was an unnecessary check?

@Taz03
Copy link
Member Author

Taz03 commented Aug 22, 2022

How did you figure out what what was an unnecessary check?

one which can and already is replaced by discord integration settings

Zabuzard
Zabuzard requested changes Aug 24, 2022
View reviewed changes
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Taz03 Taz03 requested a review from Zabuzard August 24, 2022 12:04
@marko-radosavljevic marko-radosavljevic merged commit 292071a into develop Aug 25, 2022
@marko-radosavljevic marko-radosavljevic deleted the feature/remove-unnecessary-checks branch August 25, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zabuzard Zabuzard Zabuzard approved these changes

@marko-radosavljevic marko-radosavljevic marko-radosavljevic approved these changes

Assignees

@Taz03 Taz03

Labels

enhancement New feature or request priority: normal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Disable the commands in unvalid channels

4 participants

@Taz03 @Zabuzard @DevSerendipity @marko-radosavljevic