Adding uncaught exception handling #494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taz03
previously approved these changes
Aug 14, 2022
* for scheduled services, it has to be done manually since their exception gets supressed and put into the future. also, those routines shouldnt stop if one failed
Zabuzard
dismissed stale reviews from Taz03 and marko-radosavljevic
via
ddf682c
Zabuzard
force-pushed
the
feature/uncaught_exception_handler
branch
from
fead8d1 to
ddf682c
Compare
|
quick rebase, no code changes |
|
(merging with 2 prior approvals) |
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #490. Some exceptions slipped through the logging system. Most notable, anything happening inside
Routines. Even worse, the routine actually stopped forever (until the next bot restart).This fixes the issue by:
An example of a quick test exception from a routine, which is now correctly logged: