Skip to content

Audit rework #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Aug 3, 2022
Merged

Audit rework #472

merged 20 commits into from
Aug 3, 2022

Conversation

@Taz03
Copy link
Member

@Taz03 Taz03 commented Jul 27, 2022 •
edited
Loading

  • New UI for Audit command
  • Unlimited audit length (almost)

Closes #335

Screencast.from.28-07-22.11.45.23.PM.IST.webm

@Taz03 Taz03 requested review from a team as code owners July 27, 2022 13:17
@Zabuzard
Copy link
Member

Are you "fixing" the issue by getting rid of the embeds or whats the approach here?

@Zabuzard
Copy link
Member

Zabuzard commented Jul 27, 2022 •
edited
Loading

Some other user attempted to fix this bug before already. The approach there was to add "Next and Previous" buttons at the bottom which would let u go to the next page of issues.

A bit more sophisticated though, thats for sure.

@Taz03
Copy link
Member Author

Taz03 commented Jul 27, 2022

Are you "fixing" the issue by getting rid of the embeds or whats the approach here?

Kind of, max fields limit is 25 too so it is still limited

@Taz03
Copy link
Member Author

Taz03 commented Jul 27, 2022

Some other user attempted to fix this bug before already. The approach there was to add "Next and Previous" buttons at the bottom which would let u go to the next page of issues.

That is a better solution

@Zabuzard
Copy link
Member

It is making good progress. Nice. Please tell me once it is ready for a review :)

@Taz03
Copy link
Member Author

Taz03 commented Jul 28, 2022

it is, i want someone to review the code and test the command

Zabuzard
Zabuzard requested changes Jul 28, 2022
View reviewed changes
@Taz03 Taz03 requested a review from Zabuzard July 28, 2022 15:22
@Taz03 Taz03 added enhance command Modify or improve an existing command or group of commands of the bot bug Something isn't working priority: normal labels Jul 28, 2022
Zabuzard
Zabuzard requested changes Jul 29, 2022
View reviewed changes
@Taz03 Taz03 requested review from a team and Zabuzard July 29, 2022 15:04
@Taz03 Taz03 self-assigned this Jul 30, 2022
Zabuzard
Zabuzard requested changes Aug 1, 2022
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Taz03 Taz03 merged commit 3ab9d9e into develop Aug 3, 2022
@Taz03 Taz03 deleted the feature/audit-rework branch August 3, 2022 08:39
@Taz03 Taz03 restored the feature/audit-rework branch August 3, 2022 08:39
@Taz03 Taz03 deleted the feature/audit-rework branch August 3, 2022 08:39
@Zabuzard Zabuzard mentioned this pull request Aug 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Heatmanofurioso Heatmanofurioso Heatmanofurioso approved these changes

@Zabuzard Zabuzard Zabuzard approved these changes

@Tais993 Tais993 Awaiting requested review from Tais993

Assignees

@Taz03 Taz03

Labels

bug Something isn't working enhance command Modify or improve an existing command or group of commands of the bot priority: normal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

/audit crashes if more than 10 cases

3 participants

@Taz03 @Zabuzard @Heatmanofurioso