Bugfix with /change_help_title allowing too long titles #466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* also decreased title max length to 70 to account for long categories like "[Together Java Bot]"
marko-radosavljevic
previously approved these changes
Jul 9, 2022
Taz03
requested changes
Jul 16, 2022
application/src/main/java/org/togetherjava/tjbot/commands/help/ChangeHelpTitleCommand.java
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
|
Week old, one approval, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This addresses two bugs with long titles:
/change_help_titlehad no verification on title length and hence had a really bad UX for too long titles with exceptions and no user response80, which is too long and exceeds the true limit of100when long categories are added, such as[Together Java Bot]Both issues have been fixed with this PR.