Bugfix with temp actions being revoked too early #464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tais993
previously approved these changes
Jul 7, 2022
java-coding-prodigy
requested changes
Jul 7, 2022
...rc/main/java/org/togetherjava/tjbot/commands/moderation/temp/TemporaryModerationRoutine.java
Show resolved
Hide resolved
|
Tested, works: |
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a bug with temporary moderation actions being revoked too early in certain edge cases.
Basically, the issue occurs if a user already had a temporary action in the past, which was also revoked already. The next temporary action will then be revoked too early, since the code picks up the old expired action and figures "oh, lets revoke it".
This introduces a small fix where the code will always look at the last apply-action first and only proceeds revoking if that one has already expired.