Skip to content

Conversation

Tais993
Copy link
Member

@Tais993 Tais993 commented Apr 14, 2022

Fixes the help-system not working.

This branch was accidentally based of the wrong branch, fixing in a minute!

@Tais993 Tais993 requested review from a team as code owners April 14, 2022 08:23
After updating to JDA5, GuildMessageReceviedEvent was removed.
MessageReceivedEvent has to be used instead.

To "counter" this, one can use the isFromGuild method.

I use this method, but incorrect.
I should invert the if statemen; if the message is NOT from a guild, ignore.

This modification fixes the update that broke the help system.
@Tais993 Tais993 force-pushed the bugfix/helpsystem-busy-not-working branch from 3d1475f to 4f5cc2f Compare April 14, 2022 08:29
@Tais993 Tais993 requested a review from Zabuzard April 14, 2022 08:29
@Tais993 Tais993 linked an issue Apr 14, 2022 that may be closed by this pull request
@Tais993 Tais993 added bug Something isn't working priority: critical labels Apr 14, 2022
@Tais993 Tais993 self-assigned this Apr 14, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Zabuzard
Copy link
Member

Tested locally, seems to work:

works

@Zabuzard Zabuzard merged commit bae7b79 into develop Apr 14, 2022
@Zabuzard Zabuzard deleted the bugfix/helpsystem-busy-not-working branch April 14, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: critical
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help System - channels stuck in free status
2 participants