Skip to content

Update JDA-4 to JDA-5 alpha 9 #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 29, 2022
Merged

Update JDA-4 to JDA-5 alpha 9 #420

merged 3 commits into from
Mar 29, 2022

Conversation

Tais993
Copy link
Member

@Tais993 Tais993 commented Mar 18, 2022 •
edited by java-coding-prodigy
Loading

Pull-request

Changes

  • Existing code
  • New feature

Closes Issue: #407

Description

This PR updates our project to use JDA-5 alpha 9, unlike the name might suggest, this is a stable release, but more prone to breaking changes when upgrading.
This adds support for auto-complete, time-outs, threads, context-menu's and possibly more.
To use some features, we need #368 to get merged.
In the main-time, this still adds support for other features.

@Tais993 Tais993 requested review from a team as code owners March 18, 2022 08:45
@Tais993 Tais993 requested a review from Zabuzard March 18, 2022 08:45
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.3% 0.3% Duplication

illuminator3
illuminator3 approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@illuminator3 illuminator3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Zabuzard
Zabuzard approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@Zabuzard Zabuzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of changes, but they all seem to be kinda boring and trivial. So LGTM.

@Zabuzard Zabuzard added enhancement New feature or request priority: major dependencies Pull requests that update a dependency file labels Mar 29, 2022
@Tais993
Copy link
Member Author

Tais993 commented Mar 29, 2022 •
edited
Loading

Could you rerun the license? @Zabuzard
It's stuck, again

@Zabuzard
Copy link
Member

Done

@Tais993 Tais993 merged commit 3ea40dc into develop Mar 29, 2022
@Tais993 Tais993 deleted the feature/JDAV5 branch March 29, 2022 08:56
This was referenced Mar 29, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zabuzard Zabuzard Zabuzard approved these changes

@illuminator3 illuminator3 illuminator3 approved these changes

Assignees

@Tais993 Tais993

Labels

dependencies Pull requests that update a dependency file enhancement New feature or request priority: major

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Tais993 @Zabuzard @illuminator3