Skip to content

Removed code duplication from role based moderation actions. #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 31, 2022
Merged

Removed code duplication from role based moderation actions. #417

merged 10 commits into from
Mar 31, 2022

Conversation

interacsion
Copy link
Contributor

@interacsion interacsion commented Mar 16, 2022 •
edited by Zabuzard
Loading

Introduced abstract class RevocableRoleBasedAction to remove that duplication.

Closes #414.

@interacsion interacsion requested a review from Zabuzard March 16, 2022 18:30
@interacsion interacsion requested review from a team as code owners March 16, 2022 18:30
@interacsion interacsion self-assigned this Mar 16, 2022
@interacsion interacsion added the enhancement New feature or request label Mar 16, 2022
Zabuzard
Zabuzard requested changes Mar 16, 2022
View reviewed changes
@interacsion interacsion marked this pull request as draft March 16, 2022 21:22
@interacsion
Copy link
Contributor Author

Tried using an abstract implementation. see the change.
Also, changed handleFailure() logic, to only forward an ErrorResponse to the implementation's handler, as this handler is supposed to handle errors thrown by a rest action.

@interacsion interacsion marked this pull request as ready for review March 17, 2022 22:38
@interacsion interacsion requested review from Zabuzard and Tais993 March 17, 2022 22:38
@interacsion
Copy link
Contributor Author

I'll appreciate a review.

Zabuzard
Zabuzard requested changes Mar 21, 2022
View reviewed changes
@interacsion interacsion force-pushed the bugfix/temp_mod_action_duplicate_code branch from 0509a94 to 4427e8f Compare March 30, 2022 17:23
@interacsion interacsion requested a review from Zabuzard March 30, 2022 17:34
@interacsion interacsion changed the title Re-worked the temporary moderation action's failure handling Removed code duplication from role based moderation actions. Mar 30, 2022
@interacsion
Copy link
Contributor Author

I'll appreciate a review.

@Tais993
Copy link
Member

Tais993 commented Mar 31, 2022

Could you please stop asking for reviews, use GitHub's GUI to request a review.
After 10 days or so feel free to post a comment, but I have things to do in my life, I can't constantly review on Discord, 1 day isn't a lot of time and makes me more interested in ignoring than reviewing.

Zabuzard
Zabuzard previously approved these changes Mar 31, 2022
View reviewed changes
@interacsion interacsion requested review from Tais993 and Zabuzard March 31, 2022 09:07
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 31, 2022 •
edited
Loading

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Zabuzard Zabuzard merged commit e5cd2c2 into develop Mar 31, 2022
@Zabuzard Zabuzard deleted the bugfix/temp_mod_action_duplicate_code branch March 31, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zabuzard Zabuzard Zabuzard approved these changes

@Tais993 Tais993 Tais993 approved these changes

Assignees

@interacsion interacsion

Labels
enhancement New feature or request priority: major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove code duplication on temp mod role revocation failure
3 participants
@interacsion @Tais993 @Zabuzard