Skip to content

Bugfix - Handling blocked users gracefully when reacting to their messages #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 15, 2022
Merged

Bugfix - Handling blocked users gracefully when reacting to their messages #412

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d15b5bf
warped the line that reacts to the message in a `try catch` block
interacsion Mar 14, 2022
ba3a3a0
reverted and added an handler to `queue`
interacsion Mar 14, 2022
8d554a3
Changed log message
interacsion Mar 15, 2022
a1668ab
changed `instanceof cast` style.
interacsion Mar 15, 2022
2bf68a0
spotless fix
interacsion Mar 15, 2022
8c2aa24
added descriptive comment.
interacsion Mar 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion application/src/main/java/org/togetherjava/tjbot/commands/basic/SuggestionsUpDownVoter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
import net.dv8tion.jda.api.entities.Guild;
import net.dv8tion.jda.api.entities.Message;
import net.dv8tion.jda.api.events.message.guild.GuildMessageReceivedEvent;
import net.dv8tion.jda.api.exceptions.ErrorResponseException;
import net.dv8tion.jda.api.requests.ErrorResponse;
import org.jetbrains.annotations.NotNull;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
Expand Down Expand Up @@ -56,7 +58,17 @@ private static void reactWith(@NotNull String emoteName, @NotNull String fallbac
"Unable to vote on a suggestion with the configured emote ('{}'), using fallback instead.",
emoteName);
return message.addReaction(fallbackUnicodeEmote);
}).queue();
}).queue(ignored -> {
}, exception -> {
if (exception instanceof ErrorResponseException responseException
&& responseException.getErrorResponse() == ErrorResponse.REACTION_BLOCKED) {
// User blocked the bot, hence the bot can not add reactions to their messages.
// Nothing we can do here.
return;
}

logger.error("Attempted to react to a suggestion, but failed", exception);
});
}

private static @NotNull Optional<Emote> getEmoteByName(@NotNull String name,
Expand Down