Rework command-system for JDA5 + new Discord features

[Tais993]

This PR is ready to be reviewed, but will not be merged!

Once #363 is merged, the target will be changed to develop.
For now this is only there so the chances can be reviewed in advance so the load will be lightened

Changes in this PR

Added interfaces

• Added BotCommand (getName, getVisibility, onButtonClick, onSelectionMenu, acceptComponentGenerator
• MessageContextCommand (onMessageContext)
• UserContextCommand (onUserContext)

Added adapters

• Added BotCommandAdapter adds generateComponentId, and implements the methods listed above
• ContextCommandAdapter

Renamed

• Renamed SlashCommandVisibility to CommandVisibility

Edited

• Stripped down SlashCommand (moved to BotCommand)
• Stripped down SlashCommandAdapter (moved to BotCommandAdapter)
• Made BotCommandProvider return BotCommand instead of SlashCommand

TODO

More info

Check the issue, #368

[Tais993]

This PR can be reviewed already, if we agree on my design I'll be able to already implement things into TJ-Bot so the size of this PR can decrease.

Otherwise we will receive #363 and this PR at the same time, which will take a lot of time.

[Tais993]

@Zabuzard compilation issues, compiles alright locally..

Weird caching issue or sum? Not sure, IntelliJ is complicated

[Zabuzard]

@Tais993 For your info, for #394 I have to do changes on the command system (BotCommand in your case) that abstract out the capability to create buttons and selection menus from commands. So that non-commands (routines, event listeners, ...) like ScamDetector can create them as well.

That means that I will have to move:

• acceptComponentIdGenerator - to create buttons etc
• getName() - unique name for the routing
• onButtonClick - callback
• onSelectionMenu - callback

out of the command system into a separate interface, which the commands then also implement.

For you, that means, that you will probably have to do a minor refactoring on BotCommand once its merged. Nothing critical though, I suppose.

I am thinking about calling it sth along the lines of InteractionCreator, something that can create an interaction with the user. (name to be decided lmao)

[github-actions]

This pull request is stale because it has been open 30 days with no activity. Remove stale label, comment or add the valid label or this will be closed in 5 days.

[Tais993]

Changing this to a draft, there's a few points that need to be addressed first;

No promises on when this will happen, if someone needs any of the new features hit me up and I'll prioritize this so it gets merged

The issue contains what has to be done

[Zabuzard]

@Tais993 For this PR individually, what is left to do? Nothing? Just rebasing, fixing merge conflicts, fixing sonar, quick test whether it works and done? Or is there still any content-stuff you want to be done in this PR before its shipped?

If its just getting the PR, as it is, ready for merge, I can probably do that.

[Tais993]

See issue

If we implement those features later, that would be fine too. In that case it's rebasing, and maybe sonarcloud?
So kinda just preparing for merge

[Zabuzard]

See issue

I did see it. But since you said in illus PR that the other PR can probably be merged later, I assumed that you want to ship this individually now.

I do not quite get why you want to hold back the general command rework until the extra features are there. Isn't it easier to just ship the rework now and the extra features afterwards?

Or am I confusing the two PRs now? 😆

[Tais993]

I have no idea what you mean.

The intention of this PR was to include everything the issue says, currently I haven't finished everything, therefor I'm saying "you can merge and I'll do it later" to not delay for any longer.

I never talked about an existing second PR, I just said a new PR can be made in the future for these missing features.

[illuminator3]

bump

[github-actions]

This pull request is stale because it has been open 30 days with no activity. Remove stale label, comment or add the valid label or this will be closed in 5 days.