Added event listener support for (slash) commands #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
They get registered on creation of a CommandSystem instance, this means the ReadyEvent triggers too
Tais993
force-pushed
the
event-listener-support
branch
from
d0ed6ce to
c370b54
Compare
Tais993
commented
Jan 17, 2022
application/src/main/java/org/togetherjava/tjbot/commands/system/CommandSystem.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
|
I dont like this design. Goes away from what I had in mind. I think it would be better to keep slash commands and general event listeners separated. Otherwise, eventually, we end up with a behemoth of a class that can do everything instead of separating our concerns. Maybe something up for discussion. Code-wise, looks fine though. |
|
Actually, let me propose a PR shortly which adds message receiver and generic event receiver support the way I visioned it. Edit: #345 |
|
See new PR and issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SlashCommand received onEvent(GenericEvent), SlashCommandAdapter received an event method for each event (as example, onMessageReceived(MessageReceivedEvent)
Closes #237