Skip to content

GitHub Reference feature is in wrong package #1019 #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 20, 2024
Merged

GitHub Reference feature is in wrong package #1019 #1040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5e52b94
GitHub Reference feature wrong package #1019
Jayanta-karmakar Mar 2, 2024
3ceb694
GitHub Reference feature wrong package #1019
Jayanta-karmakar Mar 2, 2024
4d79184
GitHub Command wrong package also indentation fix #1019
Jayanta-karmakar Mar 5, 2024
ee42617
spotless
Jayanta-karmakar Mar 5, 2024
c83e419
removed public modifier
Taz03 Mar 20, 2024
9ccc2de
Merge branch 'develop' into feature/rebase-gitHubReferance
Taz03 Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions application/src/main/java/org/togetherjava/tjbot/features/Features.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

import net.dv8tion.jda.api.JDA;

import org.togetherjava.tjbot.commands.github.GitHubCommand;
import org.togetherjava.tjbot.commands.github.GitHubReference;
import org.togetherjava.tjbot.config.Config;
import org.togetherjava.tjbot.config.FeatureBlacklist;
import org.togetherjava.tjbot.config.FeatureBlacklistConfig;
Expand All @@ -23,6 +21,8 @@
import org.togetherjava.tjbot.features.code.CodeMessageHandler;
import org.togetherjava.tjbot.features.code.CodeMessageManualDetection;
import org.togetherjava.tjbot.features.filesharing.FileSharingMessageListener;
import org.togetherjava.tjbot.features.github.GitHubCommand;
import org.togetherjava.tjbot.features.github.GitHubReference;
import org.togetherjava.tjbot.features.help.*;
import org.togetherjava.tjbot.features.jshell.JShellCommand;
import org.togetherjava.tjbot.features.jshell.JShellEval;
Expand Down
2 changes: 1 addition & 1 deletion .../tjbot/commands/github/GitHubCommand.java → .../tjbot/features/github/GitHubCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package org.togetherjava.tjbot.commands.github;
package org.togetherjava.tjbot.features.github;

import net.dv8tion.jda.api.events.interaction.command.CommandAutoCompleteInteractionEvent;
import net.dv8tion.jda.api.events.interaction.command.SlashCommandInteractionEvent;
Expand Down
4 changes: 2 additions & 2 deletions ...jbot/commands/github/GitHubReference.java → ...jbot/features/github/GitHubReference.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package org.togetherjava.tjbot.commands.github;
package org.togetherjava.tjbot.features.github;

import net.dv8tion.jda.api.EmbedBuilder;
import net.dv8tion.jda.api.entities.Message;
Expand Down Expand Up @@ -35,8 +35,8 @@
* the bot replies with an embed that contains info on the issue/PR.
*/
public final class GitHubReference extends MessageReceiverAdapter {
static final String ID_GROUP = "id";
private static final Logger logger = LoggerFactory.getLogger(GitHubReference.class);
static final String ID_GROUP = "id";

/**
* The pattern(#123) used to determine whether a message is referencing an issue.
Expand Down
2 changes: 1 addition & 1 deletion ...a/tjbot/commands/github/package-info.java → ...a/tjbot/features/github/package-info.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
*/
@MethodsReturnNonnullByDefault
@ParametersAreNonnullByDefault
package org.togetherjava.tjbot.commands.github;
package org.togetherjava.tjbot.features.github;

import org.togetherjava.tjbot.annotations.MethodsReturnNonnullByDefault;

Expand Down