ChatGPT Auto-Answer should not be posted when image #1018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankitsmt211
requested changes
Jan 31, 2024
application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadCreatedListener.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/utils/LinkDetections.java
Outdated
Show resolved
Hide resolved
ankitsmt211
requested changes
Jan 31, 2024
application/src/main/java/org/togetherjava/tjbot/features/utils/LinkDetections.java
Outdated
Show resolved
Hide resolved
Zabuzard
requested changes
Feb 1, 2024
application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadCreatedListener.java
Outdated
Show resolved
Hide resolved
Zabuzard
reviewed
Feb 5, 2024
application/src/main/java/org/togetherjava/tjbot/features/utils/LinkDetections.java
Outdated
Show resolved
Hide resolved
Zabuzard
reviewed
Feb 5, 2024
application/src/main/java/org/togetherjava/tjbot/features/utils/LinkFilter.java
Outdated
Show resolved
Hide resolved
Zabuzard
previously approved these changes
Feb 5, 2024
|
Why does it "redo" all commits if I just rebase? |
Zabuzard
previously approved these changes
Feb 8, 2024
SquidXTV
dismissed
Zabuzard’s stale review
The merge-base changed after approval.
|
@SquidXTV because a rebase rewrites the history (hence it requires a force-push). |
ankitsmt211
reviewed
Feb 9, 2024
application/src/main/java/org/togetherjava/tjbot/features/utils/LinkDetections.java
Outdated
Show resolved
Hide resolved
SquidXTV
force-pushed
the
feature/gpt-prevent-auto-answer-on-image
branch
from
b8b8a48 to
f29093d
Compare
Alathreon
previously requested changes
Feb 21, 2024
application/src/main/java/org/togetherjava/tjbot/features/utils/LinkDetection.java
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/utils/LinkDetection.java
Show resolved
Hide resolved
SquidXTV
force-pushed
the
feature/gpt-prevent-auto-answer-on-image
branch
from
8b3b668 to
2c58eb8
Compare
SquidXTV
force-pushed
the
feature/gpt-prevent-auto-answer-on-image
branch
from
2c58eb8 to
f033325
Compare
|
marko-radosavljevic
dismissed
Alathreon’s stale review
Reviews in question are resolved
marko-radosavljevic
deleted the
feature/gpt-prevent-auto-answer-on-image
branch
Taz03
pushed a commit
that referenced
this pull request
Mar 6, 2024
* Move link detection into separate class * Remove unused method and fix javadocs * Skip chatgpt response if message contains image or link * Fix sonarlint issues * Move fixing encoding issues to its own PR * Remove star import * Move context logic into custom method * Fix reviews * Fix reviews * Rename LinkDetections to LinkDetection
Closed
Taz03
pushed a commit
that referenced
this pull request
Mar 13, 2024
* Move link detection into separate class * Remove unused method and fix javadocs * Skip chatgpt response if message contains image or link * Fix sonarlint issues * Move fixing encoding issues to its own PR * Remove star import * Move context logic into custom method * Fix reviews * Fix reviews * Rename LinkDetections to LinkDetection
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
resolves #918
Skips generating an auto-answer if message contains images or links.
This is to prevent answers which miss context for ChatGPT to give a decent answer.