Bump org.mockito:mockito-core from 5.3.1 to 5.10.0 #1015
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
the
dependencies
|
I just checked for the ping command and it seems like that it fails because of this: UnaryOperator<SlashCommandInteractionEvent> mockOperator = event -> {
SlashCommandInteractionEvent SlashCommandInteractionEvent = spy(event);
mockInteraction(SlashCommandInteractionEvent);
return SlashCommandInteractionEvent;
};especially the It seems like it's already a Mock and thus is an illegal argument here. if (MockUtil.isMock(object)) {
throw new IllegalArgumentException("Please don't pass mock here. Spy is not allowed on mock.");
}For me it seems like that the private SlashCommandInteractionEvent spySlashCommandEvent(String jsonData) {
SlashCommandInteractionEvent event = spy(new SlashCommandInteractionEvent(jda, 0,
new SlashCommandInteractionImpl(jda, DataObject.fromJson(jsonData))));
event = mockOperator.apply(event);What should I do to fix this? UnaryOperator<SlashCommandInteractionEvent> mockOperator = event -> {
if (!MockUtil.isMock(event)) {
event = spy(event);
}
mockInteraction(event);
return event;
};it would fix all tests. :D |
SquidXTV
force-pushed
the
dependabot/gradle/org.mockito-mockito-core-5.10.0
branch
from
a36bdde to
700aaeb
Compare
SquidXTV
force-pushed
the
dependabot/gradle/org.mockito-mockito-core-5.10.0
branch
from
700aaeb to
d5a80e7
Compare
|
@dependabot rebase |
|
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
Bumps [org.mockito:mockito-core](https://github.com/mockito/mockito) from 5.3.1 to 5.10.0. - [Release notes](https://github.com/mockito/mockito/releases) - [Commits](mockito/mockito@v5.3.1...v5.10.0) --- updated-dependencies: - dependency-name: org.mockito:mockito-core dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
SquidXTV
force-pushed
the
dependabot/gradle/org.mockito-mockito-core-5.10.0
branch
from
d5a80e7 to
faf14a3
Compare
|
|
A newer version of org.mockito:mockito-core exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
What should I do about this? |
nothing, after this pr merges everything will be fine (not like we gonna miss something in the new update). And if u really want to upgrade the version manually |
* Bump org.mockito:mockito-core from 5.3.1 to 5.10.0 Bumps [org.mockito:mockito-core](https://github.com/mockito/mockito) from 5.3.1 to 5.10.0. - [Release notes](https://github.com/mockito/mockito/releases) - [Commits](mockito/mockito@v5.3.1...v5.10.0) --- updated-dependencies: - dependency-name: org.mockito:mockito-core dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Fix tests failing with new version --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Connor Schweighoefer <[email protected]>
Bumps org.mockito:mockito-core from 5.3.1 to 5.10.0.
Release notes
Sourced from org.mockito:mockito-core's releases.
... (truncated)
Commits
7e1bae8Bump org.shipkit:shipkit-auto-version from 1.2.2 to 2.0.2 (#3248)cf89d49Bump org.assertj:assertj-core from 3.25.1 to 3.25.2 (#3247)cc2ca36Bump org.shipkit:shipkit-changelog from 1.2.0 to 2.0.1 (#3245)ed01de6Bump com.diffplug.spotless from 6.24.0 to 6.25.0 (#3244)ef3dc8fImprove typing for PluginLoader#loadPlugin(..) (#3242)33dc48cBump com.github.ben-manes.versions from 0.50.0 to 0.51.0 (#3241)9173522Add support for static mocks on DoNotMockEnforcer (#3220)a021436Bump com.diffplug.spotless from 6.23.3 to 6.24.0 (#3236)e4fa639Align Javadoc configuration to Java 21 standards (#3230)71e2fdbBump org.gradle.toolchains.foojay-resolver-convention (#3234)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)