Modification of discriminator

[doshgo]

Pull-request

• I have read the contributing guidelines.
• I have read the code guidelines.
• I have created a relating issue.

Changes

• Existing code
• New feature

resolves #867

Description

Invalid discriminator(#0000) shown for users with new username system in uploaded gist by TJ-Bot.

[CLAassistant]

All committers have signed the CLA.

[ankitsmt211]

Hi, can you also add a screenshot in description after changes? thanks
usually it's a good idea to add something visual, but it's just one line so it's alright.

[ankitsmt211]

is there any reason not to use event.getAuthor().getName() here, you wouldn't need to replace anything.

There's still room for improvement, imo if we can retrieve user as Member, we can get the EffectiveName of user(nickname of user or username if it's null). Although i don't think event.getMember works here, would need to retrieve user seperately what you think @Zabuzard ?

[Zabuzard]

yes, the correct fix is to not use tags as source for this. tags are not a thing anymore and names are now unique. so we should instead put the name.

[Zabuzard]

we shouldnt put the effective name though, cause we need to be able to find users uploading malicious content even after renaming or kicked. the account name is enough (or effective name + id)

[doshgo]

Here's an image of what the change will look like.
There is an additional space between the @ and though I am not sure its necessary.
What do you guys think?

[ankitsmt211]

Here's an image of what the change will look like. There is an additional space between the @ and though I am not sure its necessary. What do you guys think?

is it after you used getName? you don't need to use @ now.
It should look like Uploaded by idkwhatimdoin

[doshgo]

@ankitsmt211 The file below is using :
description("Uploaded by " + event.getAuthor().getName());

https://github.com/Together-Java/TJ-Bot/assets/34873349/3475bed6-87ea-4f5c-a027-cc949f429497)

What else needed to be improved?

[ankitsmt211]

@ankitsmt211 The file below is using : description("Uploaded by " + event.getAuthor().getName());

https://github.com/Together-Java/TJ-Bot/assets/34873349/3475bed6-87ea-4f5c-a027-cc949f429497)

What else needed to be improved?

seems alright, you can push the changes.

[ankitsmt211]

@doshgo are you still working on this? any update, it's been a month old now.

[vishv843]

Hi, I wanna work on this. Can you assign the issue to me?

[vishv843]

This is an image showing the change.

[vishv843]

Please check out my PR #1050

[ankitsmt211]

#1050 already merged which targets the same issue, closing this one now.