Format injection in help thread titles

[Zabuzard]

Issue

There is a bug where the help-thread flow breaks down for the bot when giving a title that contains stuff relevant to string formatting.

For example a title like bad %s text %s %. test or simply test %s:

Threads are created though, so nobody is blocked.

Exception is this:

Coming from the string formatting here:

Fix

The source of the issue is that we do format twice. Hence the first format may introduce a %, which is then interpreted by the second format. Thats obviously not intended and two successive formats are dangerous anyways. It was an elegant approach, but it shouldnt be done.

We should split the text formatting so that it doesnt run format twice on the same string.

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label, comment or add the valid label or this will be closed in 5 days.