Log tag changes

[marko-radosavljevic]

Is your feature request related to a problem? Please describe.

Managing tags (creating, editing, deleting) is done on the discord. It's not under version control, and we do not know who issued tag managing command.

And since a lot of people have permission to manage tags, it would be nice to be able to audit the changes, and revert in case tag gets accidentally deleted or similar.

Describe the solution you'd like

Every /tag-manage to be logged in #mod_audit_log, so we can know who edited the tag, when, and what are the changes being made.

[interacsion]

I'll start working on that

[Zabuzard]

I'll start working on that

Awesome, enjoy! If you have any questions, feel free to ask either here or in the Discord server 😃

[Zabuzard]

Design-wise, I would maybe create a separate class that offers a method to write arbitrary messages into the log channel. And then let the tag manage command class take an instance of that class and use the method there, whenever the tags are changed.

Not sure whether the existing mod routine class would be much of a help here honestly, it has a completely different purpose and flow. But I still feel like all mod-log actions should be near to it, at least in the same package. Hence why I would just create some ModAuditLogWriter class or similar there and give it a method log public void logMessage(String message) which others can then use.

[interacsion]

Should the bot log the action instantly, or wait for the routine?

[interacsion]

do we need to log it when someone uses /tag-manage raw?

[interacsion]

also, does it need to show the content of the tag when using create etc' and/or the old content when using edit etc'?

[Zabuzard]

Should the bot log the action instantly, or wait for the routine?

Yeah, just dont connect this code to the routine at all. Imo they dont have anything to do with each other.

do we need to log it when someone uses /tag-manage raw?

No. Just the once that actually change something: create, edit, delete, ...

also, does it need to show the content of the tag when using create etc' and/or the old content when using edit etc'?

Yeah, this is actually crucial to be able to "revert" accidental changes. It has to log the state before and after the change. I would suggest to just attach them as "file" to the embed, like a before.md and after.md file or similar.

[interacsion]

I would suggest to just attach them as "file" to the embed, like a before.md and after.md file or similar.

The thing is, when I attach the file to the embed it puts the file before the embed. I think that sending the files in different messages is the way to go.