Skip to content

Conversation

olivierdalang
Copy link

This removes close_old_connections() at the end of the management command, because this prevents using call_command in the context of tests :

from django.core.management import call_command
from django.test import TestCase

class MyTestCase(TestCase):
    def test_cron(self):
        ...
        call_command('runcrons')
        # test something else here
        ...

This fails with psycopg2.InterfaceError: connection already closed, as tests are run in transaction and django needs to rollback the transaction at the end of the test.

The close_old_connections() line was added in f7de420 back in 2013, I'm pretty sure in the mean time it's become useless.

@JedrzejMaluszczak JedrzejMaluszczak force-pushed the master branch 8 times, most recently from edf6cd4 to c0bbe43 Compare May 30, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant