Skip to content

Gdext 0.3.2 had internal breaking change #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2025
Merged

Gdext 0.3.2 had internal breaking change #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
128 changes: 75 additions & 53 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ version = "0.1.0"
edition = "2021"

[workspace.dependencies]
godot = { version = "0.3", features = ["experimental-threads"] }
godot = { version = "0.3.2", features = ["experimental-threads"] }
godot-cell = "0.3"
godot-bindings = "0.3"
itertools = "0.10"
Expand Down
4 changes: 2 additions & 2 deletions derive/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ fn rust_to_variant_type(ty: &syn::Type) -> Result<TokenStream, TokenStream> {
use #godot_types::sys::GodotFfi;
use #godot_types::meta::GodotType;

<<#path as #godot_types::meta::GodotConvert>::Via as GodotType>::Ffi::VARIANT_TYPE
<<#path as #godot_types::meta::GodotConvert>::Via as GodotType>::Ffi::VARIANT_TYPE.variant_as_nil()
}
}),
T::Verbatim(_) => Err(syn::Error::new(
Expand All @@ -206,7 +206,7 @@ fn rust_to_variant_type(ty: &syn::Type) -> Result<TokenStream, TokenStream> {
use #godot_types::sys::GodotFfi;
use #godot_types::meta::GodotType;

<<#tuple as #godot_types::meta::GodotConvert>::Via as GodotType>::Ffi::VARIANT_TYPE
<<#tuple as #godot_types::meta::GodotConvert>::Via as GodotType>::Ffi::VARIANT_TYPE.variant_as_nil()
}
})
}
Expand Down
4 changes: 3 additions & 1 deletion rust-script/src/interface/export.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,9 @@ where

impl<T: ArrayElement + GodotScriptExport + GodotType> GodotScriptExport for Array<T> {
fn hint_string(custom_hint: Option<PropertyHint>, custom_string: Option<String>) -> String {
let element_type = <<T as GodotType>::Ffi as GodotFfi>::VARIANT_TYPE.ord();
let element_type = <<T as GodotType>::Ffi as GodotFfi>::VARIANT_TYPE
.variant_as_nil()
.ord();
let element_hint = <T as GodotScriptExport>::hint(custom_hint).ord();
let element_hint_string = <T as GodotScriptExport>::hint_string(custom_hint, custom_string);

Expand Down
2 changes: 1 addition & 1 deletion rust-script/src/interface/signals.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ macro_rules! signal_argument_desc {
($name:literal, $type:ty) => {
RustScriptPropDesc {
name: $name,
ty: <<<$type as GodotConvert>::Via as GodotType>::Ffi as godot::sys::GodotFfi>::VARIANT_TYPE,
ty: <<<$type as GodotConvert>::Via as GodotType>::Ffi as godot::sys::GodotFfi>::VARIANT_TYPE.variant_as_nil(),
class_name: <<$type as GodotConvert>::Via as GodotType>::class_name(),
exported: false,
hint: PropertyHint::NONE,
Expand Down
Loading