Skip to content

Conversation

antiguru
Copy link
Member

Update to flatcontainer 0.3.0, which changes the CopyInto trait into a Push trait. Update Timely's PushInto trait in the same manner, i.e., the parameter is what should be pushed and self is the container.

Split PushContainer into a push function on Container and a SizableContainer that knows capacity, preferred_capacity, and resize functions, which the capacity container builder and PushPartitioned require. It also appears as a restriction on ContainerBuilder, as did PushContainer in the past.

Adds a implementation for flatcontainer::Region for TimelyStack, it's not used yet but would allow us to store columnated data in flatcontainer.

@antiguru antiguru requested a review from frankmcsherry May 24, 2024 18:57
@antiguru antiguru force-pushed the sizable_container branch from 39ad4fa to 3700864 Compare May 24, 2024 19:14
Copy link
Member

@frankmcsherry frankmcsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A few questions, but nothing deeply consequential.

Signed-off-by: Moritz Hoffmann <[email protected]>
@antiguru antiguru merged commit 7042fa8 into TimelyDataflow:master May 25, 2024
@antiguru antiguru deleted the sizable_container branch May 25, 2024 18:34
@github-actions github-actions bot mentioned this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants