Log messages over enter/leave channels #507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some evidence that his actually helps:
|
antiguru
approved these changes
Feb 23, 2023
This commit adds `MessageEvent` logging for messages traveling over `enter`/`leave` channels.
teskje
force-pushed
the
enterleave-message-logging
branch
from
d962b74 to
992104f
Compare
antiguru
approved these changes
Feb 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
MessageEventlogging for messages traveling overenter/leavechannels.The motivation is to fix missing record counts in MZ's memory graphs: https://github.com/MaterializeInc/database-issues/issues/4126.