Skip to content

Conversation

antiguru
Copy link
Member

In certain situations, a handle survives longer than we would like to wait for a flush to happen. In this cases, an explicit call to cease can help to indicate to the rest of the system that no more data follows immediately, which is equivalent to dropping the handle.

Specifically, in async code the handle can be long-lived and survive await points, which makes it more important to signal momentary completion to the system.

Signed-off-by: Moritz Hoffmann [email protected]

In certain situations, a handle survives longer than we would like to wait
for a flush to happen. In this cases, an explicit call to cease can help
to indicate to the rest of the system that no more data follows
immediately, which is equivalent to dropping the handle.

Specifically, in async code the handle can be long-lived and survive await
points, which makes it more important to signal momentary completion to the
system.

Signed-off-by: Moritz Hoffmann <[email protected]>
Copy link
Member

@frankmcsherry frankmcsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, though as discussed it's awkward that we can't really say what this function does other than flush some buffers. It does not seem to require (either idiomatically, or through the signature) that you actually "cease" so much as force a flush of the buffers.

@frankmcsherry frankmcsherry merged commit 51212fe into TimelyDataflow:master Jan 24, 2023
@github-actions github-actions bot mentioned this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants