Skip to content

Activate operators that may want to shut down #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Activate operators that may want to shut down #488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions timely/src/progress/subgraph.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@ where
incomplete_count,
activations,
temp_active: BinaryHeap::new(),
maybe_shutdown: Vec::new(),
children: self.children,
input_messages: self.input_messages,
output_capabilities: self.output_capabilities,
Expand Down Expand Up @@ -242,6 +243,7 @@ where
// shared activations (including children).
activations: Rc<RefCell<Activations>>,
temp_active: BinaryHeap<Reverse<usize>>,
maybe_shutdown: Vec<usize>,

// shared state written to by the datapath, counting records entering this subgraph instance.
input_messages: Vec<Rc<RefCell<ChangeBatch<TInner>>>>,
Expand Down Expand Up @@ -461,6 +463,7 @@ where

// Drain propagated information into shared progress structure.
for ((location, time), diff) in self.pointstamp_tracker.pushed().drain() {
self.maybe_shutdown.push(location.node);
// Targets are actionable, sources are not.
if let crate::progress::Port::Target(port) = location.port {
if self.children[location.node].notify {
Expand All @@ -477,6 +480,18 @@ where
}
}

// Consider scheduling each recipient of progress information to shut down.
self.maybe_shutdown.sort();
self.maybe_shutdown.dedup();
for child_index in self.maybe_shutdown.drain(..) {
let child_state = self.pointstamp_tracker.node_state(child_index);
let frontiers_empty = child_state.targets.iter().all(|x| x.implications.is_empty());
let no_capabilities = child_state.sources.iter().all(|x| x.pointstamps.is_empty());
if frontiers_empty && no_capabilities {
self.temp_active.push(Reverse(child_index));
}
}

// Extract child zero frontier changes and report as internal capability changes.
for (output, internal) in self.shared_progress.borrow_mut().internals.iter_mut().enumerate() {
self.pointstamp_tracker
Expand Down