Add a tuple timestamp #455
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
Timestampimplementation for(T1, T2), following Rust's lead that this is a lexicographically ordered sequence, rather than a partially ordered product (useorder::Productfor that).I think the path summary representation is .. pessimistic, but not incorrect. It allows summaries to both coordinates, which are both applied. In principle, advancing the outer coordinator could zero the inner coordinate, so
(summ1, summ2)could be "ifsumm1is non-zero applysumm1and set the second coordinate toT2::minimum()subjected tosumm2".I didn't do that, and just applied the summaries to each coordinate, promising more of an advance than is strictly required.
In writing this up, I took the opportunity to relayout
order.rswhich, not having a second implementation, lacked for organization.