Skip to content

fix: low priority implicits etc #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2016
Merged

fix: low priority implicits etc #2

merged 1 commit into from
Oct 10, 2016

Conversation

maowug
Copy link
Contributor

@maowug maowug commented Oct 10, 2016 •
edited
Loading

Change:

  • typo: lowpriority extractor implicits

trait SeqExtractor moved to the same scope with trait Extractor. It makes more sense to put SeqExtractor outside LowPriorityExtractor(Implicits).

@Atry
Copy link
Collaborator

Atry commented Oct 10, 2016 •
edited
Loading

http://docs.scala-lang.org/style/files.html

As a rule, files should contain a single logical compilation unit. By “logical” I mean a class, trait or object.

@maowug
Copy link
Contributor Author

maowug commented Oct 10, 2016

@Atry Done. Didn't notice the file name.

@Atry Atry merged commit 3dd4a30 into ThoughtWorksInc:master Oct 10, 2016
@Atry
Copy link
Collaborator

Atry commented Oct 10, 2016

Thank you. I prefer to keep SeqExtractor in Extractor for backward-compatibility.

Atry added a commit that referenced this pull request Jul 1, 2023
@Atry
Merge pull request #2 from ThoughtWorksInc/template
98e0ca3 
Create .gitpod.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Atry Atry Atry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maowug @Atry