Skip to content

Conversation

CassianoRafael
Copy link
Contributor

This PR addresses a potential issue in the rawAddPrefix method where, if the provided SQL query does not contain keywords like "from", "into", "update", "join", or "describe" (e.g. functions and procedures), the $table array would be empty, leading to a PHP deprecated warning in the newer versions.

The proposed solution adds a conditional check to ensure that there are table name matches before proceeding with the replacement.

@CassianoRafael
Copy link
Contributor Author

@avbdr when you have time, can you please review it?

@ThingEngineer
Copy link
Owner

Thanks for the pull request, @CassianoRafael! This looks like a valuable fix for a potential null issue in the rawAddPrefix method. I appreciate you catching this and taking the time to contribute (especially as a first-time contributor!).

The issue @CassianoRafael identified is likely valid. Here's why:

PHP Deprecated Warnings: In newer PHP versions, accessing properties of potentially null variables can trigger warnings. The proposed fix with a conditional check avoids this scenario.
Unexpected Behavior: If the $table array remains empty due to missing keywords like "from," unexpected behavior could occur when the prefix is added. This fix helps prevent such issues.

@ThingEngineer ThingEngineer merged commit 727754c into ThingEngineer:master May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants