GpuArray sort operation #488
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abergeron
requested changes
Jul 31, 2017
src/gpuarray/sort.h
Outdated
| #endif | ||
|
|
||
| #define SHARED_SIZE_LIMIT 1024U | ||
| #define SAMPLE_STRIDE 128 |
There was a problem hiding this comment.
Don't expose this in a public header
src/gpuarray/sort.h
Outdated
| GpuKernel k_ranks_idxs; | ||
| GpuKernel k_merge; | ||
| GpuKernel k_merge_global; | ||
| } GpuSortKernels; |
There was a problem hiding this comment.
You probably want to hide those structures also.
src/gpuarray/sort.h
Outdated
| } | ||
| #endif | ||
|
|
||
| #endif No newline at end of file |
src/gpuarray_sort.c
Outdated
| * | ||
| */ | ||
|
|
||
| //#define checkErr(x) checkErrors(x, __FILE__, __LINE__) |
src/gpuarray_sort.c
Outdated
| * with this source code for terms and conditions that govern your use of | ||
| * this software. Any use, reproduction, disclosure, or distribution of | ||
| * this software and related documentation outside the terms of the EULA | ||
| * is strictly prohibited. |
There was a problem hiding this comment.
It feels a bit weird to refer to an EULA that is not there. Perhaps there is a way to reword that.
There was a problem hiding this comment.
You should remove the paragraph about the EULA. The rest is fine.
src/gpuarray_sort.c
Outdated
| * This software contains source code provided by NVIDIA Corporation. | ||
| * | ||
| * Read more at: http://docs.nvidia.com/cuda/eula/index.html#ixzz4lUbgXjsr | ||
| * Follow us: @GPUComputing on Twitter | NVIDIA on Facebook |
abergeron
approved these changes
Aug 1, 2017
|
jenkins tests this please |
|
jenkins test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort implementation for 1D contiguous data.
int GpuArray_sort(GpuArray *dstKey, GpuArray *srcKey, uint sortDir, GpuArray *arg)sortDir: 0 for descending order and 1 for ascending order
arg empty GpuArray to store argsort output. Set to NULL for regular sort. Supported types for the GpuArray are GA_UINT and GA_ULONG