Add PHP Core Round #9 #74
Conversation
|
🚀 Deployed on https://deploy-pr-74--thephpfoundation.netlify.app |
|
|
||
| Following are some changes that did not go through an RFC process because they are either planned, bug fixes, or progressive enhancements. There are automated unit and integration tests for each of these changes, the PHP core developers review all pull requests. | ||
|
|
There was a problem hiding this comment.
It may make sense to highlight outside of the commit list the improvement in performance of MBString by Alex Dowad.
There was a problem hiding this comment.
You are right, they are noteworthy indeed. I mentioned them above the rest of the commit log. I included Alex's work on mbstring, along with the Random extension and const/include RFC mentions.
|
|
||
| RFC by Derick Rethans, proposed to introduce Date/Time extension-specific exceptions and errors. This detailed RFC suggests more specificity in the exceptions with exception classes such as `DateInvalidTimeZoneException`, and `DateMalformedPeriodStringException` as well as promoting some of the current PHP warnings to Error exceptions. | ||
|
|
||
| The vote was accepted, and is pending implementation. |
There was a problem hiding this comment.
It's now further then that, there is a PR that's nearly ready to be merged: php/php-src#10366
There was a problem hiding this comment.
Thank you, I will update it.
There was a problem hiding this comment.
(and make sure to update the text if the post goes live after the PR is merged).
| - Fix undefined behaviour in `phpdbg_load_module_or_extension` in [GH-10157](https://github.com/php/php-src/pull/10157) by Niels Dossche | ||
| - Update test for changed behaviour of GMP constructor in [a24659e70c](https://github.com/php/php-src/commit/a24659e70c) by Niels Dossche | ||
| - Fix [GH-10072](https://github.com/php/php-src/issues/10072): PHP crashes when execute_ex is overridden and a __call trampoline is used from internal code in [233ffccc35](https://github.com/php/php-src/commit/233ffccc35) by Derick Rethans 💜 | ||
| - Make sure to disable JIT when overriding execute_ex in [b489e0f2b8](https://github.com/php/php-src/commit/b489e0f2b8) by Derick Rethans 💜 |
|
Thank you @saundefined for your changes as well, I included them and pushed. |
|
|
||
| * **RFC Under Discussion: [Path to Saner Increment/Decrement operators](https://wiki.php.net/rfc/saner-inc-dec-operators) 💜** | ||
|
|
||
| PHP's increment and decrement operators can have some surprising behaviours when used with types other than int and float. Various previous attempts 1) 2) 3) have been made to improve the behaviour of these operators, but none have been implemented. The goal of this RFC by George Peter Banyard is to normalize the behaviour of `$v++` and `$v--` to be the same as `$v += 1` and `$v -= 1`, respectively. |
There was a problem hiding this comment.
The "various attempts" with the numbers looks odd.
There was a problem hiding this comment.
Thank you. You are right it indeed it was missing the links to the past RFCs. Fixed now.
Co-authored-by: Sergey Panteleev <[email protected]>
|
The commits list is really long this time. What do you think about putting it in |
No description provided.