Skip to content

Fix mypy errors in circular_linked_list.py and swap_nodes.py #9707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 4, 2023
Merged

Fix mypy errors in circular_linked_list.py and swap_nodes.py #9707

merged 5 commits into from
Oct 4, 2023

Conversation

@tianyizheng02
Copy link
Contributor

@tianyizheng02 tianyizheng02 commented Oct 4, 2023 •
edited
Loading

Describe your change:

Fixes #9710

Fix mypy errors in data_structures/linked_list/circular_linked_list.py and data_structures/linked_list/swap_nodes.py that were let through in #9668. These errors are causing every new PR to fail the pre-commit check.

My fixes primarily consisted of assert statements and type hints in order to convince mypy of (implicitly understood) type guarantees.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 4, 2023
@tianyizheng02 tianyizheng02 marked this pull request as draft October 4, 2023 15:11
@tianyizheng02 tianyizheng02 changed the title Fix mypy errors in circular_linked_list.py Fix mypy errors in circular_linked_list.py and swap_nodes.py Oct 4, 2023
@tianyizheng02 tianyizheng02 marked this pull request as ready for review October 4, 2023 15:37
@tianyizheng02 tianyizheng02 requested a review from cclauss October 4, 2023 15:37
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 4, 2023
@cclauss cclauss merged commit dfdd781 into TheAlgorithms:master Oct 4, 2023
@tianyizheng02 tianyizheng02 deleted the fix-circ-ll-mypy branch October 4, 2023 16:13
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes

Assignees

No one assigned

Labels

enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Failing precommit.ci due to error in circular_linked_list.py file

2 participants

@tianyizheng02 @cclauss