Bloom Filter #8615
Merged
Bloom Filter #8615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorithms-keeper
bot
added
awaiting reviews
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
algorithms-keeper
bot
removed
the
require type hints
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
algorithms-keeper
bot
removed
the
require descriptive names
CaedenPH
requested changes
Apr 6, 2023
Comment on lines
60
to
66
| assert b.exists("Titanic") | ||
| assert b.exists("Avatar") | ||
|
|
||
| assert b.exists("The Goodfather") in (True, False) | ||
| assert b.exists("Interstellar") in (True, False) | ||
| assert b.exists("Parasite") in (True, False) | ||
| assert b.exists("Pulp Fiction") in (True, False) |
There was a problem hiding this comment.
We use doctest to test our modules via a workflow
There was a problem hiding this comment.
Moved to module docstring
Comment on lines
32
to
39
| print( | ||
| f"""\ | ||
| [exists] value = {value} | ||
| hash = {self.format_bin(h)} | ||
| filter = {self.format_bin(self.bitstring)} | ||
| res = {res} | ||
| """ | ||
| ) |
There was a problem hiding this comment.
Suggested change
| print( | |
| f"""\ | |
| [exists] value = {value} | |
| hash = {self.format_bin(h)} | |
| filter = {self.format_bin(self.bitstring)} | |
| res = {res} | |
| """ | |
| ) |
In the CONTRIBUTING it says
- return all calculation results instead of printing or plotting them
I don't think these prints are necessary
There was a problem hiding this comment.
moved to method and called in doctest
Comment on lines
20
to
26
| print( | ||
| f"""\ | ||
| [add] value = {value} | ||
| hash = {self.format_bin(h)} | ||
| filter = {self.format_bin(self.bitstring)} | ||
| """ | ||
| ) |
There was a problem hiding this comment.
Suggested change
| print( | |
| f"""\ | |
| [add] value = {value} | |
| hash = {self.format_bin(h)} | |
| filter = {self.format_bin(self.bitstring)} | |
| """ | |
| ) |
Same here
Comment on lines
98
to
100
| assert ( | ||
| abs(estimated_error_rate - error_rate) <= 0.05 | ||
| ) # 5% absolute margin calculated experiementally |
There was a problem hiding this comment.
Same as above, this should be converted to a doctest
There was a problem hiding this comment.
In this case I removed the test. I found difficult to make tests with random values.
algorithms-keeper
bot
added
the
require type hints
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
algorithms-keeper
bot
removed
the
require type hints
cclauss
requested changes
Apr 8, 2023
Comment on lines
31
to
47
| Not added elements should return False ... | ||
| >>> "The Goodfather" in bloom | ||
| False | ||
| >>> bloom.format_hash("The Goodfather") | ||
| '00011000' | ||
| >>> "Interstellar" in bloom | ||
| False | ||
| >>> bloom.format_hash("Interstellar") | ||
| '00000011' | ||
| >>> "Parasite" in bloom | ||
| False | ||
| >>> bloom.format_hash("Parasite") | ||
| '00010010' | ||
| >>> "Pulp Fiction" in bloom | ||
| False | ||
| >>> bloom.format_hash("Pulp Fiction") | ||
| '10000100' |
There was a problem hiding this comment.
Should this be The Goodfather or The Godfather? https://www.imdb.com/title/tt0068646
Suggested change
| Not added elements should return False ... | |
| >>> "The Goodfather" in bloom | |
| False | |
| >>> bloom.format_hash("The Goodfather") | |
| '00011000' | |
| >>> "Interstellar" in bloom | |
| False | |
| >>> bloom.format_hash("Interstellar") | |
| '00000011' | |
| >>> "Parasite" in bloom | |
| False | |
| >>> bloom.format_hash("Parasite") | |
| '00010010' | |
| >>> "Pulp Fiction" in bloom | |
| False | |
| >>> bloom.format_hash("Pulp Fiction") | |
| '10000100' | |
| Not added elements should return False ... | |
| >>> not_present_films = ("The Goodfather", "Interstellar", "Parasite", "Pulp Fiction") | |
| >>> {film: bloom.format_hash(film) for film in not_present_films)} | |
| {'The Goodfather': '00011000', 'Interstellar': '00000011', 'Parasite': '00010010': 'Pulp Fiction': '10000100'} | |
| >>> any(film in bloom for film in not_present_films) | |
| False |
There was a problem hiding this comment.
I had to reduce the tuple in order to avoid the following ruff error:
Also tried pretty-print, but it doesn't match
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks for teaching me that.
I also had to divide in multiple lines the previous line:
algorithms-keeper
bot
added
awaiting changes
Co-authored-by: Christian Clauss <[email protected]>
algorithms-keeper
bot
added
awaiting reviews
Co-authored-by: Christian Clauss <[email protected]>
for more information, see https://pre-commit.ci
This reverts commit 35fa5f5.
cclauss
approved these changes
Apr 8, 2023
algorithms-keeper
bot
removed
the
awaiting reviews
for more information, see https://pre-commit.ci
algorithms-keeper
bot
removed
the
awaiting reviews
tianyizheng02
pushed a commit
to tianyizheng02/Python
that referenced
this pull request
May 29, 2023
* Bloom filter with tests * has functions constant * fix type * isort * passing ruff * type hints * type hints * from fail to erro * captital leter * type hints requested by boot * descriptive name for m * more descriptibe arguments II * moved movies_test to doctest * commented doctest * removed test_probability * estimated error * added types * again hash_ * Update data_structures/hashing/bloom_filter.py Co-authored-by: Christian Clauss <[email protected]> * from b to bloom * Update data_structures/hashing/bloom_filter.py Co-authored-by: Christian Clauss <[email protected]> * Update data_structures/hashing/bloom_filter.py Co-authored-by: Christian Clauss <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * syntax error in dict comprehension * from goodfather to godfather * removed Interestellar * forgot the last Godfather * Revert "removed Interestellar" This reverts commit 35fa5f5. * pretty dict * Apply suggestions from code review * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update bloom_filter.py --------- Co-authored-by: Christian Clauss <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.