-
-
Notifications
You must be signed in to change notification settings - Fork 47.1k
My favorite palindrome #7455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
My favorite palindrome #7455
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9590eb8
My favorite palindrome
cclauss e744f70
updating DIRECTORY.md
a1c9be3
Update is_palindrome.py
cclauss 2a5f27a
Update is_palindrome.py
cclauss 35ad485
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 171501d
Update strings/is_palindrome.py
cclauss 33b31f4
Update is_palindrome.py
cclauss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,9 +1,8 @@ | ||||||
def is_palindrome(s: str) -> bool: | ||||||
""" | ||||||
Determine whether the string is palindrome | ||||||
:param s: | ||||||
:return: Boolean | ||||||
>>> is_palindrome("a man a plan a canal panama".replace(" ", "")) | ||||||
Determine if the string s is palindrome. | ||||||
|
||||||
>>> is_palindrome("A man, A plan, A canal -- Panama!") | ||||||
True | ||||||
>>> is_palindrome("Hello") | ||||||
False | ||||||
|
@@ -14,15 +13,15 @@ def is_palindrome(s: str) -> bool: | |||||
>>> is_palindrome("Mr. Owl ate my metal worm?") | ||||||
True | ||||||
""" | ||||||
# Since Punctuation, capitalization, and spaces are usually ignored while checking | ||||||
# Palindrome, we first remove them from our string. | ||||||
s = "".join([character for character in s.lower() if character.isalnum()]) | ||||||
# Since punctuation, capitalization, and spaces are often ignored while checking | ||||||
# palindromes, we first remove them from our string. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
s = "".join(character for character in s.lower() if character.isalnum()) | ||||||
return s == s[::-1] | ||||||
|
||||||
|
||||||
if __name__ == "__main__": | ||||||
s = input("Enter string to determine whether its palindrome or not: ").strip() | ||||||
s = input("Please enter string to see if it is a palindrome: ") | ||||||
cclauss marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
if is_palindrome(s): | ||||||
print("Given string is palindrome") | ||||||
print(f"'{s}' is a palindrome.") | ||||||
else: | ||||||
print("Given string is not palindrome") | ||||||
print(f"'{s}' is not a palindrome.") |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.