Skip to content

Improve doctest and comment for maximum sub-array problem #1503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 28, 2019
Merged

Improve doctest and comment for maximum sub-array problem #1503

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e7dca33
Doctest and comment for maximum sub-array problem
poyea Oct 28, 2019
8c1bbd2
Update max_sub_array.py
poyea Oct 28, 2019
deb0b92
Update max_sub_array.py
poyea Oct 28, 2019
322ce03
Fix doctest
poyea Oct 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions dynamic_programming/max_sub_array.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,15 +43,22 @@ def find_max_cross_sum(A, low, mid, high):

def max_sub_array(nums: List[int]) -> int:
"""
Finds the contiguous subarray (can be empty array)
which has the largest sum and return its sum.
Finds the contiguous subarray
which has the largest sum and return its sum.

>>> max_sub_array([-2,1,-3,4,-1,2,1,-5,4])
>>> max_sub_array([-2, 1, -3, 4, -1, 2, 1, -5, 4])
6
An empty (sub)array has sum 0.
>>> max_sub_array([])
0
If all elements are negative, the largest subarray would be the empty array,
having the sum 0.
>>> max_sub_array([-1,-2,-3])
0
>>> max_sub_array([5,-2,-3])
5
>>> max_sub_array([31, −41, 59, 26, −53, 58, 97, −93, −23, 84])
187
"""
best = 0
current = 0
Expand All @@ -64,6 +71,9 @@ def max_sub_array(nums: List[int]) -> int:


if __name__ == "__main__":
"""
A random simulation of this algorithm.
"""
inputs = [10, 100, 1000, 10000, 50000, 100000, 200000, 300000, 400000, 500000]
tim = []
for i in inputs:
Expand Down