Skip to content

Fix code style in README.md #12843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 24, 2025
Merged

Fix code style in README.md #12843

merged 4 commits into from
Aug 24, 2025

Conversation

chandrapola
Copy link
Contributor

@chandrapola chandrapola commented Jul 12, 2025 •
edited by MaximSmolskiy
Loading

Describe your change:

Fix #12840

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?
    Fixes code style from black to ruff in the README or project documentation . This change is made after checking .pre-commit-config.yaml in the repo

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword:

@chandrapola chandrapola requested a review from mindaugl July 15, 2025 19:33
@chandrapola
Copy link
Contributor Author

chandrapola commented Jul 18, 2025 •
edited
Loading

@mindaugl thank you very much for your approval on the PR.

The PR fixes the code style to ruff instead of black.

It's currently blocked due to needing an approval from someone with write access.
Would really appreciate it if someone could take a moment to review it 🙏

@chandrapola chandrapola mentioned this pull request Jul 28, 2025
Closed
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Aug 24, 2025
@MaximSmolskiy MaximSmolskiy changed the title Fix #12840 code style Fix code style in README.md Aug 24, 2025
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Aug 24, 2025
@MaximSmolskiy MaximSmolskiy merged commit c2b9003 into TheAlgorithms:master Aug 24, 2025
5 checks passed
cclauss pushed a commit to cclauss/Python that referenced this pull request Aug 25, 2025
@chandrapola @MaximSmolskiy @cclauss
Fix code style in README.md (TheAlgorithms#12843)
bd9db8c 
* Fix TheAlgorithms#12840 code style

* Update README.md

---------

Co-authored-by: Maxim Smolskiy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaximSmolskiy MaximSmolskiy MaximSmolskiy approved these changes

@mindaugl mindaugl Awaiting requested review from mindaugl

+1 more reviewer

@anandfresh anandfresh anandfresh approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

code style in README is showing black though ruff is used
4 participants
@chandrapola @MaximSmolskiy @anandfresh @mindaugl