-
Notifications
You must be signed in to change notification settings - Fork 20.5k
feat: added rotating calipers #6669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yadhu-vipin
wants to merge
11
commits into
TheAlgorithms:master
Choose a base branch
from
yadhu-vipin:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+334
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6669 +/- ##
============================================
+ Coverage 75.75% 75.90% +0.14%
- Complexity 5772 5798 +26
============================================
Files 703 704 +1
Lines 19777 19884 +107
Branches 3832 3846 +14
============================================
+ Hits 14982 15092 +110
+ Misses 4215 4214 -1
+ Partials 580 578 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: Fix Rotating Calipers: Correct Diameter and Width Calculations
“This PR adds the Rotating Calipers algorithm and its tests. The CI may show unrelated test failures (e.g., BloomFilterTest), but my changes are isolated to the geometry package and pass all their own tests.”
Description:
This PR fixes the
RotatingCalipers
implementation for calculating the diameter and minimum width of convex polygons.Changes made:
diameter
method to correctly compute the farthest pair of points using the rotating calipers technique. Previous calculations returned incorrect distances for simple polygons.width
method to compute the true minimum width of the convex polygon, based on perpendicular projections along each edge.testDiameterSimpleTriangle
andtestWidthSimpleTriangle
to match the mathematically correct expected values.minAreaBoundingRectangle
, remain consistent with correct convex hull ordering.Impact:
Triangles and other simple polygons now return the correct diameter and width.
Unit tests pass with accurate geometric values.
References:
Rotating Calipers algorithm (Shamos, 1978)
Convex hull computation for ordered points