EntityReflection provider

[janpecha]

No description provided.

[dakujem]

I like these changes 👍

Allow me to make one request:

1. Please allow the PropertyFactory to use a custom set of filters, passes, methods etc.
   • either use an interface+injection approach instead of the static method calls
   • or at least allow for static extension of PropertyFilters (i.e. "mixin"), allowing to swap the particular implementation

---

Sidenote:

Even though I would most probably approach the "EntityReflection issue" differenly, using a factory for the whole EntityReflection instance, your implementation is equally as good and serves the purpose of extensibility.

// what I would do
static::$reflections[$class][$mapperClass] =
    static::getReflectionFactory()->create($class, $mapperClass)
;

I'm also not sure if calling the interface implementor a "provider" is a good idea, as it does not provide a thing, rather it providers for another class, but maybe I'm just picky. :-)

All in all, good job!

[janpecha]

Please allow the PropertyFactory to use a custom set of filters, passes, methods etc.

If I understand correctly, it isn't needed - just call new Property(...) and set filters, methods,... via constructor.

---

using a factory for the whole EntityReflection instance

Yeah, factory was first idea but it isn't so easy. It requires rewrite architecture of EntityReflection completely. This PR is "compromise solution".

---

I'm also not sure if calling the interface implementor a "provider" is a good idea

IMHO it's ok, because it provides informations for reflection. Alternative we can rename interface to EntityReflectionFactory and rename methods to createProperties(), createGetters() & createSetters(). Maybe it will be better.

[dakujem]

But it is not possible to change the PropertyFactory ... or is it? Is there a way to customize the filters e.t.c.? I can't see it just by looking at the code.

The "provider" name is better then. You are right, it provides for something else.

[janpecha]

Ok, so you want:

1. create Property from annotation via PropertyFactory
2. overwrite filters,... with custom values

I will think about it.

[janpecha]

@dakujem I added new parameter callable $factory into PropertyFactory::createFromAnnotation() (2902d9e). Is it ok for your needs?