-
Notifications
You must be signed in to change notification settings - Fork 36
Update Tester and Docs #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Oh... okay. PHP 5.4 and 5.5 issue. |
|
I plan to drop PHP 5 support and update Tester in Lean Mapper 4.x. For now IMHO would be fine add only
IMHO it's unnecessary because everybody needs something else - set another php.ini, run to coverage, Windows vs Unix issues, etc.
I think we can remove it. |
|
That composer command Personally, I would only keep the local command as default for |
|
I thought about it and I have some notes.
So I think contributing manual is good idea but we don't need |
|
I agree with Tester v1.7 it does not bring the utility I had in mind and with upgrade to Tester v2 you lose support for legacy PHP. Though I think it is a good idea to just have |
|
It would be great split this PR on 2 parts:
We can add contributors manual in separate PR and this PR can wait for LM 4.x. What do you thing? |
|
@janpecha Good idea. How can i do that? Or will you? |
|
I like it. Let's keep this one open until v4 (or close it, it's up to you, I don't mind). |
Changes:
-Cswitch (see below)composer test(run all tests)composer test-local(run all tests using local PHP configuration, via the-CTester switch)Maybe some info about contribution can be added by you.
Also, what about the following sentence ??