fix: Trigger correct notifications when moving directories #866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes directory move notifications in the file system watcher to trigger the correct events based on the destination path. The key change ensures that when a directory is moved outside the watched directory, a delete event is properly triggered instead of a rename event.
- Fixed notification filter logic to use appropriate filters for different file system object types (files vs directories)
- Updated path matching logic to properly handle directory moves that cross watched directory boundaries
- Added comprehensive test coverage for directory move scenarios
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Tests/Testably.Abstractions.Tests/FileSystem/FileSystemWatcher/NotifyFiltersTests.cs | Added new test cases for directory move operations within and outside watched directories |
| Source/Testably.Abstractions.Testing/Storage/InMemoryStorage.cs | Fixed notification filter to use type-appropriate filters instead of hardcoded FileName filter |
| Source/Testably.Abstractions.Testing/FileSystem/FileSystemWatcherMock.cs | Updated path matching and event triggering logic to handle directory moves across watched boundaries |
Source/Testably.Abstractions.Testing/FileSystem/FileSystemWatcherMock.cs
Show resolved
Hide resolved
Source/Testably.Abstractions.Testing/FileSystem/FileSystemWatcherMock.cs
Show resolved
Hide resolved
Test Results 37 files ± 0 37 suites ±0 29m 46s ⏱️ + 9m 5s For more details on these failures, see this check. Results for commit d8fc93f. ± Comparison against base commit df2e064. This pull request removes 36390 and adds 36450 tests. Note that renamed tests count towards both.This pull request removes 1784 skipped tests and adds 1784 skipped tests. Note that renamed tests count towards both. |
|
|
This is addressed in release v4.3.8. |
This was referenced Sep 17, 2025
Closed
Closed
This was referenced Sep 18, 2025
Closed
Closed
Closed
Closed
This was referenced Sep 22, 2025
This was referenced Oct 7, 2025
This was referenced Oct 14, 2025
This was referenced Oct 24, 2025
This was referenced Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes directory move notifications in the file system watcher to trigger the correct events based on the destination path. The key change ensures that when a directory is moved outside the watched directory, a delete event is properly triggered instead of a rename event.
Key changes: