Skip to content

fix: throw an UnauthorizedAccessException immediately when enumerating a directory without access #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 12, 2025
Merged

fix: throw an UnauthorizedAccessException immediately when enumerating a directory without access #860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e6fec9
fix: throw an `UnauthorizedAccessException` immediately when enumerat…
vbreuss Sep 12, 2025
a5e501e
Move using to the enumeration
vbreuss Sep 12, 2025
04684af
Run authorization tests only on windows
vbreuss Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions Source/Testably.Abstractions.Testing/Storage/InMemoryStorage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,14 @@ public IEnumerable<IStorageLocation> EnumerateLocations(
throw ExceptionFactory.DirectoryNotFound(location.FullPath);
}

return EnumerateLocationsImpl(location, type, requestParentAccess, searchPattern,
enumerationOptions, parentContainer);
IDisposable parentAccess = new NoOpDisposable();
if (requestParentAccess)
{
parentAccess = parentContainer.RequestAccess(FileAccess.Read, FileShare.ReadWrite);
}

return EnumerateLocationsImpl(location, type, searchPattern,
enumerationOptions, parentAccess);
}

/// <summary>
Expand All @@ -210,17 +216,10 @@ public IEnumerable<IStorageLocation> EnumerateLocations(
private IEnumerable<IStorageLocation> EnumerateLocationsImpl(
IStorageLocation location,
FileSystemTypes type,
bool requestParentAccess,
string searchPattern,
EnumerationOptions? enumerationOptions,
IStorageContainer parentContainer)
IDisposable parentAccess)
{
IDisposable parentAccess = new NoOpDisposable();
if (requestParentAccess)
{
parentAccess = parentContainer.RequestAccess(FileAccess.Read, FileShare.ReadWrite);
}

using (parentAccess)
{
enumerationOptions ??= EnumerationOptionsHelper.Compatible;
Expand Down
69 changes: 69 additions & 0 deletions Tests/Testably.Abstractions.Testing.Tests/FileSystem/DirectoryMockTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
using Testably.Abstractions.Testing.FileSystem;

namespace Testably.Abstractions.Testing.Tests.FileSystem;

public class DirectoryMockTests
{
[Fact]
public async Task
EnumerateDirectories_UnauthorizedParentAccess_ShouldThrowUnauthorizedAccessExceptionImmediately()
{
Skip.IfNot(Test.RunsOnWindows);

string path = "foo";
MockFileSystem fileSystem = new();
IDirectoryInfo sut = fileSystem.Directory.CreateDirectory(path);
fileSystem.WithAccessControlStrategy(
new DefaultAccessControlStrategy((p, _)
=> !p.EndsWith(path, StringComparison.Ordinal)));

void Act() =>
_ = fileSystem.Directory.EnumerateDirectories(path);

await That(Act).Throws<UnauthorizedAccessException>()
.WithMessageContaining($"'{sut.FullName}'").And
.WithHResult(-2147024891);
}

[Fact]
public async Task
EnumerateFiles_UnauthorizedParentAccess_ShouldThrowUnauthorizedAccessExceptionImmediately()
{
Skip.IfNot(Test.RunsOnWindows);

string path = "foo";
MockFileSystem fileSystem = new();
IDirectoryInfo sut = fileSystem.Directory.CreateDirectory(path);
fileSystem.WithAccessControlStrategy(
new DefaultAccessControlStrategy((p, _)
=> !p.EndsWith(path, StringComparison.Ordinal)));

void Act() =>
_ = fileSystem.Directory.EnumerateFiles(path);

await That(Act).Throws<UnauthorizedAccessException>()
.WithMessageContaining($"'{sut.FullName}'").And
.WithHResult(-2147024891);
}

[Fact]
public async Task
EnumerateFileSystemEntries_UnauthorizedParentAccess_ShouldThrowUnauthorizedAccessExceptionImmediately()
{
Skip.IfNot(Test.RunsOnWindows);

string path = "foo";
MockFileSystem fileSystem = new();
IDirectoryInfo sut = fileSystem.Directory.CreateDirectory(path);
fileSystem.WithAccessControlStrategy(
new DefaultAccessControlStrategy((p, _)
=> !p.EndsWith(path, StringComparison.Ordinal)));

void Act() =>
_ = fileSystem.Directory.EnumerateFileSystemEntries(path);

await That(Act).Throws<UnauthorizedAccessException>()
.WithMessageContaining($"'{sut.FullName}'").And
.WithHResult(-2147024891);
}
}
Loading