fix: Close channel correctly when receiving SSH_Message_Channel_Close #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbenhagen
force-pushed
the
fix/116-channel-close
branch
from
fcfd5f9 to
be8a401
Compare
Fixes TerminalStudio#116 When receiving a SSH_Message_Channel_Close message, the channel was not being properly closed. This caused the stdout stream to remain open, preventing the drain() operation from completing. The fix: 1. Let the channel handle the close message properly 2. Added test to verify channel close behavior
cbenhagen
force-pushed
the
fix/116-channel-close
branch
from
be8a401 to
519c628
Compare
|
@vicajilau did you have a chance to look at this yet? |
vicajilau
approved these changes
Feb 8, 2025
|
Very good job @cbenhagen, publishing a new version in a few moments 🚀 |
|
Thanks mate! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #116
When receiving a SSH_Message_Channel_Close message, the channel was not being properly closed. This caused the stdout stream to remain open, preventing the drain() operation from completing.
The fix:
Test case demonstrates that the stdout stream is properly closed when receiving a close message from the remote side.