Skip to content

Conversation

akdalin-hee
Copy link
Contributor

@akdalin-hee akdalin-hee commented Jan 3, 2024

…Textnput visually hidden.

JIRA link

TD-3341

Description

Add placeholder for empty labels. Make empty labaels associated with Textnput visually hidden..

Screenshots

Attach screenshots on mobile, tablet and desktop.


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

@akdalin-hee akdalin-hee changed the title Add placeholder for empty labels. Make empty labaels associated with … Add placeholder for empty labels. Make empty labaels associated with Textnput visually hidden. Jan 3, 2024
@OluwatobiAwe OluwatobiAwe merged commit 844e3ce into main Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants