Skip to content

Conversation

OluwatobiAwe
Copy link
Collaborator

@OluwatobiAwe OluwatobiAwe commented Sep 6, 2023

JIRA link

TD-2191

Description

The aria-required attribute isn't valid for a radio button .This was highlighted by the aXe accessibility test plugin.
The rules guiding the use of aria for radio button doesn't contain aria-required based on the link below
MDN_Radio and W3_Radio

Screenshots

Attach screenshots on mobile, tablet and desktop.


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

@OluwatobiAwe OluwatobiAwe merged commit 319b2ac into main Sep 6, 2023
@OluwatobiAwe OluwatobiAwe deleted the TD-2191 branch September 6, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants