Skip to content

Conversation

OluwatobiAwe
Copy link
Collaborator

@OluwatobiAwe OluwatobiAwe commented Jun 7, 2023

JIRA link

TD-1871

Description

  • Extend NHSUK view component to accept a text divider(OR) while providing the name of the radio item to display after the text divider
  • Allow Date Input label to be configured as page header.

Screenshots

DateInput1
DateInput2
DividerRadio


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

Radio items with a text divider
Date Input with option to set as page header
@OluwatobiAwe OluwatobiAwe merged commit c86c564 into main Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants