Skip to content

Conversation

OluwatobiAwe
Copy link
Collaborator

@OluwatobiAwe OluwatobiAwe commented May 24, 2023

JIRA link

TD-1682

Description

modification of the component package to add the nhsuk-u-reading-width class to the nhsuk-error-summary div to ensure content and error summary border does not exceed the reading width.

Screenshots

Attach screenshots on mobile, tablet and desktop.


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

@kevwhitt-hee kevwhitt-hee merged commit f0e62bd into main May 25, 2023
@kevwhitt-hee kevwhitt-hee deleted the Develop/Fixes/TD-1682-add-reading-width-class-to-the-error-summary branch May 25, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants