Skip to content

Conversation

manishagarwalnhs
Copy link
Collaborator

@manishagarwalnhs manishagarwalnhs commented Apr 28, 2023

JIRA link

https://hee-tis.atlassian.net/browse/TD-1397

Description

There is a issue in Mobile view when there is any long error validation msg showing on the below screens. This is caused by the textinput view component having a css style which is not required.

Screenshots

WavePlugin
Error-Register-Digital-Learning-Solutions


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

@kevwhitt-hee kevwhitt-hee merged commit 43d6e7c into main May 24, 2023
@kevwhitt-hee kevwhitt-hee deleted the Develop/Fixes/TD-1397_Mobile_view_issue_for_longer_validation_message branch May 24, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants