Skip to content

Conversation

frank-hee
Copy link
Contributor

@frank-hee frank-hee commented Jul 28, 2025

JIRA link

TD-5836

Description

css definitions relating to banner images and "checkbox css trick" checkboxes was moved from media query to base styles.

Screenshots

image image image image image image image image

Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
  • Written or updated tests for the changes (accessibility ui tests for views, tests for controller, data services, services, view models created or modified) and made sure all tests are passing
  • Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
  • Tested any Views or partials created or changed with Wave Chrome plugin. Addressed any valid accessibility issues and documented any invalid errors
  • Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the MR and need to be tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
    Either:
  • Documented my work in Confluence, updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
  • Confirmed that none of the work that I have undertaken requires any updates to documentation

@frank-hee frank-hee requested a review from AnjuJose011 July 28, 2025 14:25
@frank-hee frank-hee self-assigned this Jul 28, 2025
@frank-hee frank-hee added the bug Something isn't working label Jul 28, 2025
@AnjuJose011 AnjuJose011 merged commit 69fe7e3 into RC Jul 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants