Skip to content

Conversation

sherif-olaboye
Copy link
Contributor

JIRA link

https://hee-tis.atlassian.net/browse/TD-5562

Description

I adjusted the SaveProfileName method to check whether frameworkId is not null or 0, and if so, it returns the CompetencyAssessmentFeatures view to allow selecting Competency Assessment Features.
Added CompetencyAssessmentFeatures GET and POST methods to render and submit Competency Assessment Features

Added CompetencyAssessmentFeatures view to allow selection of Competency Assessment Features

Added CompetencyAssessmentSummary GET and POST methods to render and submit Competency Assessment Summary

Added CompetencyAssessmentSummary view to display Competency Assessment Summary

Added UpdateCompetencyAssessmentFeaturesTaskStatus method to insert or update competency assessment task status

Added UpdateSelfAssessmentFromFramework method to update self-assessment details from the framework

Added InsertSelfAssessmentStructure method to insert self-assessment details into SelfAssessmentStructure

Screenshots

Framework page
image
Create competency assessment page
image

Features competency assessment page
image

Summary competency assessment page
image

task list page
image


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
  • Written or updated tests for the changes (accessibility ui tests for views, tests for controller, data services, services, view models created or modified) and made sure all tests are passing
  • Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
  • Tested any Views or partials created or changed with Wave Chrome plugin. Addressed any valid accessibility issues and documented any invalid errors
  • Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the MR and need to be tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
    Either:
  • Documented my work in Confluence, updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
  • Confirmed that none of the work that I have undertaken requires any updates to documentation

Copy link
Contributor

@kevwhitt-hee kevwhitt-hee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sherif-olaboye, this looks good. I think we need to introduce the multipage form service though, to retain the user's selections for assessment name and features forms so that they can be retained before they are committed to the database. We need this so that the forms load with their chosen values when they click "Change" links on the summary screen.

@sherif-olaboye
Copy link
Contributor Author

@sherif-olaboye, this looks good. I think we need to introduce the multipage form service though, to retain the user's selections for assessment name and features forms so that they can be retained before they are committed to the database. We need this so that the forms load with their chosen values when they click "Change" links on the summary screen.

Done

@kevwhitt-hee kevwhitt-hee merged commit accd0ae into DLS-Release-v1.3.0 Sep 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants