Skip to content

Conversation

dcharbonnier
Copy link

The order of the results does not matter on those cases and tests are randomly failing on sharedb-mongo due to this problem

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.431%

Totals Coverage Status
Change from base Build 9: 0.0%
Covered Lines: 81
Relevant Lines: 84

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 28, 2018

Pull Request Test Coverage Report for Build 12

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.431%

Totals Coverage Status
Change from base Build 9: 0.0%
Covered Lines: 81
Relevant Lines: 84

💛 - Coveralls

Copy link

@curran curran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea and implementation looks good, but there is a minor formatting issue where 3 spaces are used as indentation.

test/query.js Outdated
// Mongo queries.

var sortSnapshot =function(snapshots) {
return snapshots.sort(function (a, b) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent indentation here.

Copy link

@curran curran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@gkubisa gkubisa merged commit 52dbfc2 into Teamwork:master Jul 9, 2018
@gkubisa
Copy link

gkubisa commented Jul 9, 2018

Nice one! Thanks @dcharbonnier and @curran

@curran
Copy link

curran commented Jul 9, 2018

Hooray!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants