Skip to content

Conversation

birkskyum
Copy link
Member

@birkskyum birkskyum commented Mar 10, 2025

Copy link

nx-cloud bot commented Mar 10, 2025

View your CI Pipeline Execution ↗ for commit a3d8a29.

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 4m 27s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 50s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-10 11:36:59 UTC

Copy link

pkg-pr-new bot commented Mar 10, 2025

Open in Stackblitz

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@3732

@tanstack/create-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/create-router@3732

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@3732

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@3732

@tanstack/create-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/create-start@3732

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@3732

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@3732

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@3732

@tanstack/react-router-with-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-with-query@3732

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@3732

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@3732

@tanstack/react-start-config

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-config@3732

@tanstack/react-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-plugin@3732

@tanstack/react-start-router-manifest

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-router-manifest@3732

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@3732

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@3732

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@3732

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@3732

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@3732

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@3732

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@3732

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@3732

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@3732

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@3732

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@3732

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@3732

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@3732

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@3732

@tanstack/solid-start-config

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-config@3732

@tanstack/solid-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-plugin@3732

@tanstack/solid-start-router-manifest

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-router-manifest@3732

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@3732

@tanstack/start

npm i https://pkg.pr.new/TanStack/router/@tanstack/start@3732

@tanstack/start-api-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-api-routes@3732

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@3732

@tanstack/start-config

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-config@3732

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@3732

@tanstack/start-server-functions-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-client@3732

@tanstack/start-server-functions-fetcher

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-fetcher@3732

@tanstack/start-server-functions-handler

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-handler@3732

@tanstack/start-server-functions-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-server@3732

@tanstack/start-server-functions-ssr

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-ssr@3732

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@3732

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@3732

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@3732

commit: a3d8a29

@birkskyum birkskyum merged commit 96e0a1d into main Mar 10, 2025
5 checks passed
@birkskyum birkskyum deleted the fix(solid-router-devtools,react-router-devtools)--add-core-package-and-solid-js-as-dependencies branch March 10, 2025 11:38
@graup
Copy link
Contributor

graup commented Mar 10, 2025

Wait, why is solid-js a dependency of the react-router-devtools package? It's a copy-paste error right?

@birkskyum
Copy link
Member Author

birkskyum commented Mar 10, 2025

The devtools is a solidjs app that is mounted from react/solid/other-framework. This way we only have to implement the UI once.

It's the same for the query devtools.

@graup
Copy link
Contributor

graup commented Mar 10, 2025

Oh, I see, thanks. 👍 I was confused by the new dependency in my react app.

leesb971204 pushed a commit to leesb971204/router that referenced this pull request Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants