Skip to content

Conversation

@badsyntax
Copy link
Contributor

@badsyntax badsyntax commented Jun 16, 2022

Fixes #255

  • We set the RouteMatch status after loading the elements and (optional) loader
  • The loader can also set the status
  • Thus, we only set the resolved status for RouteMatch'es without loaders, to prevent overriding the status set by the loader

I guess you could rework this logic many ways but i thought this was the easiest to follow.

@vercel
Copy link

vercel bot commented Jun 16, 2022

@badsyntax is attempting to deploy a commit to the Tanstack Team on Vercel.

A member of the Team first needs to authorize it.

@tom-ricci
Copy link

Hoping this gets merged eventually.

@tannerlinsley tannerlinsley merged commit ee8a8a4 into TanStack:main Nov 10, 2022
@nx-cloud
Copy link

nx-cloud bot commented Feb 15, 2025

View your CI Pipeline Execution ↗ for commit 784ece7.

Command Status Duration Result
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2m 2s View ↗
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-09 02:38:53 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ErrorElement not rendered

3 participants