Skip to content

fix(solid-query): add compat types #8940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 2, 2025
Merged

fix(solid-query): add compat types #8940

merged 2 commits into from
Apr 2, 2025

Conversation

@birkskyum
Copy link
Member

@birkskyum birkskyum commented Apr 2, 2025 •
edited
Loading

backwards compatible CreateQueryOptions, CreateQueryResult

@nx-cloud
Copy link

nx-cloud bot commented Apr 2, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 886e8b4.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 2m 13s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 12s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-02 19:06:44 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Apr 2, 2025

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8940

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8940

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8940

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8940

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8940

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8940

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8940

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8940

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8940

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8940

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8940

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8940

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8940

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8940

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8940

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8940

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8940

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8940

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8940

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8940

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8940

commit: 886e8b4

@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

Sizes for commit 886e8b4:

Branch Bundle Size
Main
This PR

@codecov
Copy link

codecov bot commented Apr 2, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.45%. Comparing base (1202ba0) to head (886e8b4).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8940       +/-   ##
===========================================
+ Coverage   44.07%   79.45%   +35.38%     
===========================================
  Files         200       15      -185     
  Lines        8021      331     -7690     
  Branches     1763       63     -1700     
===========================================
- Hits         3535      263     -3272     
+ Misses       4058       56     -4002     
+ Partials      428       12      -416
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools ∅ <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query 78.20% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@birkskyum birkskyum merged commit 2770a91 into main Apr 2, 2025
7 checks passed
@birkskyum birkskyum deleted the fix(solid-query)--add-compat-types branch April 2, 2025 19:08
birkskyum added a commit that referenced this pull request Apr 3, 2025
@birkskyum
Revert "fix(solid-query): add compat types (#8940)"
51d173f 
This reverts commit 2770a91.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

package: solid-query

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@birkskyum